Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to print detailed exception info if filename is empty #23

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

guitargeek
Copy link
Contributor

This can happen for example with jitted code, and would lead to this ugly printout otherwise:

python exception (at :0 )

Maybe a bit pedantic, but our unit tests in ROOT were testing for the exact wording, which is why I suggest to fix this.

This can happen for example with jitted code, and would lead to this
ugly printout otherwise:
```
python exception (at :0 )
```
Maybe a bit pedantic, but our unit tests in ROOT were testing for the
exact wording, which is why I suggest to fix this.
@wlav wlav merged commit 3a14868 into wlav:master Jun 26, 2024
@guitargeek guitargeek deleted the exceptions branch June 27, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants