-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to mirai
2.0.0
#197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… where it improves clarity
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 30 32 +2
Lines 2257 2487 +230
==========================================
+ Hits 2257 2487 +230 ☔ View full report in Codecov by Sentry. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prework
Related GitHub issues and pull requests
mirai
2.0 #193Summary
crew_terminate_process()
.mirai
2.0.0 with the pair 1 poly protocol (Migrate tomirai
2.0 #193). Most notably, all workers now share the same URL instead of having different web sockets for different workers. This gets rid ofcrew
's previous "slotted" model for workers.push()
. (The task must be popped first before another task of the same name can be submitted.) This allows controllers to use hash tables to track tasks, which makespush()
andpop()
orders of magnitude faster. It is also needed for the new retry mechanism based on backup controllers and controller groups.scale()
andwait()
to increase responsiveness.wait(mode = "all")
for controller groups.ws://
(andwss://
) totcp://
(andtls+tcp://
) (Migrate tomirai
2.0 #193).pop()
andcollect()
more efficient.pop()
is 64 times faster."launcher"
column of the results to"controller"
.summary()
.Remarks
The package coverage workflow is failing on GitHub Actions. I don't know why, but dozens of
testthat
tests are failing in that workflow. I don't know why. It passes locally andcovr
reports 100% coverage there.