merge

wlandau · Jan 31, 2025 · fa22fdf · fa22fdf
2 parents ab8aeaa + e28d0c7
commit fa22fdf
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/R/crew_controller.R b/R/crew_controller.R
@@ -611,10 +611,15 @@ crew_class_controller <- R6::R6Class(
       } else {
         .timeout <- seconds_timeout * 1000
       }
+      tasks <- .subset2(private, ".tasks")
       if (is.null(name)) {
-        name <- basename(tempfile(pattern = "unnamed_task_"))
+        name <- name_task_tempfile()
+        name <- if_any(
+          is.null(.subset2(tasks, name)),
+          name,
+          name_task_nanonext()
+        )
       }
-      tasks <- .subset2(private, ".tasks")
       if (!is.null(.subset2(tasks, name))) {
         crew_error(
           message = paste(

diff --git a/R/utils_names.R b/R/utils_names.R
@@ -2,6 +2,14 @@ name_worker <- function(launcher, worker) {
   paste("crew", launcher, worker, sep = "-")
 }
 
+name_task_tempfile <- function() {
+  basename(tempfile(pattern = "unnamed_task_"))
+}
+
+name_task_nanonext <- function() {
+  paste0("unnamed_task_", nanonext::random(n = 32L))
+}
+
 is_named <- function(x) {
   if (!is.list(x) || length(x) < 1L) {
     return(TRUE)

diff --git a/tests/testthat/test-utils_names.R b/tests/testthat/test-utils_names.R
@@ -16,3 +16,11 @@ crew_test("eval_tidyselect()", {
   out <- eval_tidyselect(expr = rlang::new_quosure(NULL), choices = "x")
   expect_equal(out, character(0L))
 })
+
+crew_test("name_task_tempfile()", {
+  expect_true(is.character(name_task_tempfile()))
+})
+
+crew_test("name_task_nanonext()", {
+  expect_true(is.character(name_task_nanonext()))
+})