Skip to content

Commit

Permalink
data/aws: Set 20m creation timeouts for instances
Browse files Browse the repository at this point in the history
We've been hitting the default 10m timeout recently, starting around
[1].  Use the creation timeout knob [2] to wait a bit longer before
giving up on AWS.  20m matches the value we've used bumping this
timeout for other resources in 1ec2758 (data/aws/vpc/master-elb:
Bump load-balancer timeouts to 20m, 2019-08-27, openshift#2279) and previous.
There's no guarantee that 20m will be sufficient, the issue could be
due to internal AWS issues like a shortage of on-demand instances of
the requested type in the requested availability zone.  But it gives
AWS an even easier target to hit ;).

[1]: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_console/2708/pull-ci-openshift-console-master-e2e-aws-console-olm/8584
[2]: https://www.terraform.io/docs/providers/aws/r/instance.html#timeouts
  • Loading branch information
wking committed Sep 13, 2019
1 parent 3ee1ad1 commit 22ef6ec
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions data/data/aws/bootstrap/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,10 @@ resource "aws_instance" "bootstrap" {
},
var.tags,
)

timeouts {
create = "20m"
}
}

resource "aws_lb_target_group_attachment" "bootstrap" {
Expand Down
4 changes: 4 additions & 0 deletions data/data/aws/master/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,10 @@ resource "aws_instance" "master" {
},
var.tags,
)

timeouts {
create = "20m"
}
}

resource "aws_lb_target_group_attachment" "master" {
Expand Down

0 comments on commit 22ef6ec

Please sign in to comment.