Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the performance issue #168

Merged

Conversation

lucamug
Copy link
Contributor

@lucamug lucamug commented May 23, 2019

Fix for the performance issue #167

@wking-io wking-io merged commit deeacc1 into wking-io:master May 25, 2019
@harrysarson
Copy link

Does this commit not break the CI?

@wking-io
Copy link
Owner

Nope! Those are all just CI tests for the upcoming docs site. They do not relate to the package itself.

@harrysarson
Copy link

I am seeing this:

$ npm test
> [email protected] test /home/travis/build/wking-io/elm-live
> nyc ava './lib/test.js' --cwd './lib' && npm run report
  ✔ Exits if `--no-recover`
  ✔ Passes correct args to `elm make`
  ✔ Spawns `--path-to-elm` instead of `elm` if given
  ✖ Starts elmServe and chokidar with correct config reloads the app when an HTML, JS or CSS static file changes
  ✔ `--open`s the default browser
  ✔ Serves at the specified `--port`
  ✔ Serves on the specified `--host`
  ✖ Serves from the specified `--dir` watches the right files
  ✔ `--pushstate to support client-side routing
  ✔ gets watched paths from the Elm package file
  ✔ --before-build and --after-build work
  ✔ Skips `--before-build` and `--after-build` when empty
  ✔ Informs of `--before-build` and `--after-build` run errors
  ✔ Shouts if `elm` can’t be found (335ms)
  ✔ Prints any other `elm make` error (161ms)
  ✔ Shouts if the `--before-build` or `--after-build` executable can’t be found
  ✔ Prints any other `--before-build` or `--after-build` command error
  ✔ Informs of compile errors (174ms)
  ✔ Redirects elm make stdio (139ms)
  ✔ Watches all `**/*.elm` files in the current directory
  ✔ debounce debounces (203ms)
  2 tests failed

at https://travis-ci.org/wking-io/elm-live/builds/536097068.

@harrysarson
Copy link

Additionally, this pull request seems to break master:
image

@harrysarson harrysarson mentioned this pull request Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants