Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getSendCredentials doesn't work anymore #18

Open
hughdavenport opened this issue Nov 25, 2014 · 0 comments · May be fixed by #27
Open

getSendCredentials doesn't work anymore #18

hughdavenport opened this issue Nov 25, 2014 · 0 comments · May be fixed by #27

Comments

@hughdavenport
Copy link

https://github.com/fin1te/safecurl/blob/master/src/fin1te/SafeCurl/SafeCurl.php#L136 checks the $url as an array for the keys user or pass, but the keys returned are hardcoded at https://github.com/fin1te/safecurl/blob/master/src/fin1te/SafeCurl/Url.php#L62 to only be originalURL cleanURL and parts, and never have user and/or pass, but that will be in cleanURL
justinsteven added a commit to justinsteven/safecurl that referenced this issue Oct 4, 2019
@justinsteven
Fix check for credentials in URL
758ed5d 
Fixes wkcaj#18
@justinsteven justinsteven linked a pull request Oct 4, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix check for credentials in URL justinsteven/safecurl
1 participant
@hughdavenport