-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build arm64 wheels on windows #43
base: master
Are you sure you want to change the base?
Conversation
@henryiii I don't think this worked following the change to give precedence to |
Another unrelated question: CIBW generates a warning about arm64 Python 3.8 wheels (which I think should probably be removed from the build matrix in any case, that's a weird combination). Attempting to do so within |
No colon, that's only for tests - universal wheels needed a way to skip the either of the two possibilities when testing, so there's a colon for I'll look at the issue soon, currently on paternity leave so am a bit slow. |
Could you add: [tool.scikit-build]
cmake.verbose = true
logging.level = "INFO" So we can see a bit more about what's happening? |
done. |
It won’t build with conflicts, unfortunately. |
oops, rebased. |
pyproject.toml
Outdated
@@ -29,6 +30,9 @@ build-dir = "build/{wheel_tag}" | |||
# Build stable ABI wheels for CPython 3.12+ | |||
wheel.py-api = "cp312" | |||
|
|||
cmake.verbose = true | |||
logging.level = "INFO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logging.level = "INFO" | |
logging.level = "DEBUG" |
Sorry, a bit more info would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I committed this change just now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henryiii did the more detailed log message offer any useful info?
Yes, looks like a bug on my end:
Also, I want to look at pybind/pybind11#5083; the official word from FindPython is you shouldn't |
No, wait, that does say |
@henryiii does anything change here now that we have arm64 windows builders? (https://github.blog/2024-06-03-arm64-on-github-actions-powering-faster-more-efficient-build-systems/) |
Wow, I knew the linux ones were coming, a bit of a surprise the Windows ones came too. That’s great. Going to be a little tricky to test though until open source ones are available (“by end of year”). I can do some extra testing on my local windows arm machine, but I think everything should just work if you’re not cross compiling. |
No description provided.