do not convert words to lower case unless necessary in to pascal #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisey
reviewed
Feb 5, 2024
packages/common/src/strings.ts
Outdated
| return words.join(''); | ||
| const originalWords = splitIntoWords(str); | ||
| const strNoConversionToLower = originalWords.map((word) => capitalizeFirstLetter(word)).join(''); | ||
| if (new RegExp('[a-z]').test(strNoConversionToLower)) { |
There was a problem hiding this comment.
I guess another option would be:
export function toPascalCase(str: string): string {
if (/^[a-z]+$/i.test(str)) {
return capitalizeFirstLetter(str);
}
// ...
}(Would work slightly differently with numbers, but handling numbers is weird in general).
alisey
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that HTTPRequest will stay as is
and myHTTPRequest will become MyHTTPRequest instead of MyHttpRequest
** when upgrading the version in codux delete string util tests