Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cachedProcessFile should not based on mtime #2526

Merged
merged 1 commit into from
May 30, 2022
Merged

fix: cachedProcessFile should not based on mtime #2526

merged 1 commit into from
May 30, 2022

Conversation

barak007
Copy link
Collaborator

After noticing mtime based cache can lead to unexpected false negative.
This PR removes the mtime based caching in the cachedProcessFile

idoros
idoros approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@idoros idoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Now we how many times do you want to run it?

@tomrav tomrav merged commit cb0e86d into master May 30, 2022
@tomrav tomrav deleted the barak/better-cache-invalidation branch May 30, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoros idoros idoros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barak007 @idoros @tomrav