fix: cases with mixin moved compound selector #2397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issues:
1) ambiguity of a mixed-in CSS class and root class
The issue happens when a mixed class is compounded with
.root:state
(root class withcustom-pseudo-class
). The issue is that there is a bug in the process of mixin that loses the actual root symbol when a stylesheet class other then root is mixed:mixin.st.css:
entry.st.css:
valid selector:
.entry__c.mixin__root.mixin--x
error selector:
.entry__c.mixin__root:x
// root symbol is "wrongly" replaced with mix class and:x
custom-pseudo-state is unresolved2) multiple compound selectors after mixin
When compound selectors are connected after mixin class, they need to move to the beginning of the selector with the mixin if it is moved:
mixin.st.css:
entry.st.css:
valid selector:
.entry__c.mixin--mix-state.mixin__root
error selector:
.entry__c.mixin__root:mix-state
// mix-state is not moved/transformed