Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export StVar type #2276

Merged
merged 3 commits into from
Jan 18, 2022
Merged

fix: export StVar type #2276

merged 3 commits into from
Jan 18, 2022

Conversation

tzachbon
Copy link
Contributor

@tzachbon tzachbon commented Jan 18, 2022 •
edited
Loading

Exporting StVar type since it's a public API

@tzachbon tzachbon requested a review from AviVahl January 18, 2022 08:39
@tzachbon tzachbon changed the title fix: export StVar type fix: export StVar type Jan 18, 2022
idoros
idoros requested changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@idoros idoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be exported out of index, just the transformer and the runtime/types

@tzachbon
Copy link
Contributor Author

I don't think this should be exported out of index, just the transformer and the runtime/types

@idoros I do not agree with that statement.
Since StylableExports is something that the user Interacts with, he might want to declare a stVar variable and use its type.
It's not a Stylable internals type.

barak007
barak007 requested changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@barak007 barak007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to RuntimeStVar

@tzachbon tzachbon merged commit d9705fd into master Jan 18, 2022
@tzachbon tzachbon deleted the tzach/export-st-var-type branch January 18, 2022 13:46
tzachbon added a commit that referenced this pull request Feb 21, 2022
@tzachbon
fix: export StVar type (#2276)
725b7ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barak007 barak007 barak007 requested changes

@idoros idoros idoros approved these changes

@AviVahl AviVahl Awaiting requested review from AviVahl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzachbon @idoros @barak007