-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support CLI multiple projects #2086
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple-stylable-projects
…ple-stylable-projects
…to keep the process live when debugging
…ple-stylable-projects
barak007
approved these changes
Dec 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
barak007
approved these changes
Dec 30, 2021
tomrav
reviewed
Jan 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple of comments for the readme
…ple-stylable-projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part 2 of CLI improvements #1996
Goals
node_modules
..js
extension from resolved paths when fix!: unify resolvePath, always resolve request via resolver and remove resolve from fileProcessor #2135 merged.Generator
name toIndexGenerator
.extension
option.messages.ts
.Changes
@wixc3/resolve-directory-context
for the default projects resolution.visitMetaCSSDependenciesBFS
supports js dependency callbackresolve requests
- the defaultrequests
resolution method. It will take the project raw entities and will output the resolved project in the relevant order.resolve options
- includes options calculation methods.process projects
- has the process project main method that resolves multi-project config to raw project entities.projects config
- this is the main file related to config resolution that exports theprojectsConfig
method which is the main method for resolving the projects.build
method into two parameters (build options [defined by the user], and build metadata).DirectoryProcessService
which works only on its relevant scope.src
path andout
paths.Testing
generate-index
andbuild
specs were changed to match the newbuild
method API.config-options
spec tests the resolution of options.config-presets
spec test the resolution of presets and multiple presets.config-project
spec tests all of the cases that can occur from multiple projects (resolution order, multi-options resolution, etc...)cli-watch
refactor to support tests for single build and multiple builds.cli-test-kit
to@stylable/e2e-test-kit
.Test helpers