[v2] [Android] TestID for BottomTab: The key must be an application-specific resource id.

[saleksandras]

Issue Description

Android app crash on setting testID of BottomTab.

Android log:

java.lang.IllegalArgumentException: The key must be an application-specific resource id.
03-03 19:38:32.875 14063 14063 E AndroidRuntime:     at android.view.View.setTag(View.java:19661)
03-03 19:38:32.875 14063 14063 E AndroidRuntime:     at com.reactnativenavigation.presentation.BottomTabPresenter.applyOptions(BottomTabPresenter.java:57)
03-03 19:38:32.875 14063 14063 E AndroidRuntime:     at com.reactnativenavigation.viewcontrollers.bottomtabs.BottomTabsController.applyOptions(BottomTabsController.java:90)
...

Error line in code:

https://github.com/wix/react-native-navigation/blob/master/lib/android/app/src/main/java/com/reactnativenavigation/presentation/BottomTabPresenter.java#L57

This issue was introduce with this commit:
bfdd41f#diff-fe7845e05fe8da4f48d10c4da23403e5

Code Snippets

Navigation.setRoot({
  root: {
    bottomTabs: {
        children: [
          {
            stack: {
              children: [
                {
                  component: {
                    name: COMPONENT,
                  },
                },
              ],
              options: {
                bottomTab: {
                  text: 'Tab name',
                  testID: 'TAB_ID',
                  icon: tabIcon,
                },
              },
            },
          },
        ]
      }
    }
});

---

Environment

• React Native Navigation version: 2.13.1
• React Native version: 0.56.0 - 0.58.6
• Platform(s) (iOS, Android, or both?): Android

[minhtrungaa]

Just update the version few minutes ago, this happens.

[stockrel]

+1, seems to happen also when not setting any testID for bottomTabs

[holparb]

Happens to me as well with testIDs defined for tabs.
Issue is not present in RNN v2.11, but is there in v2.13.1.

[charpeni]

cc @guyca

[NweThazin]

I also encounter this issue on RNN version "^2.13.1".
thanks

[djnsu]

same here

[skumarcm]

I am facing the same issue with version 2.14.0 as well.

[jinshin1013]

This is blocking few people to upgrade to the latest version of RNN. If anyone could make a PR, that'd be so helpful.

[guyca]

Hey guys, I'm was unable to reproduce this crash in the playground app. Could anyone post a root declaration which crashes in the playground app?

[Oguntoye]

testID: 'TAB_ID',

i discovered a fix for now.
The fix for now is to downgrade to 2.11.0

npm install --save [email protected]

[trungthanhnt]

You can fix by comment this line: bottomTabs.setTag(i, tab.testId.get(null));
in this file:line (BottomTabPresenter.java:57)

[jinshin1013]

It's really weird, I just tried the same configuration on the playground app, but everything seems to be working fine. We must be missing something here.