Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/2787 scrollto gets stuck on android #4327

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Bugfix/2787 scrollto gets stuck on android #4327

merged 5 commits into from
Jan 10, 2024

Conversation

gosha212
Copy link
Contributor

@gosha212 gosha212 commented Jan 4, 2024 •
edited by d4vidi
Loading

Description

In this pull request, I have fixed the problem with interfering with gesture navigation.
Used an Android API for getting the gesture insets and shifted the scroll starting point from the edge of the screen

For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@gosha212 gosha212 requested a review from d4vidi as a code owner January 4, 2024 15:46
@gosha212 gosha212 linked an issue Jan 4, 2024 that may be closed by this pull request
.scrollTo() gets stuck on Android #2787
Closed
d4vidi
d4vidi requested changes Jan 7, 2024
View reviewed changes
Copy link
Collaborator

@d4vidi d4vidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👍🏻
Some comments / suggestions / questions - inline 🙏🏻

d4vidi
d4vidi approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@d4vidi d4vidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@gosha212 gosha212 force-pushed the bugfix/2787-scrollto-gets-stuck-on-android branch from d8105c1 to 374bd34 Compare January 10, 2024 06:01
@gosha212 gosha212 enabled auto-merge January 10, 2024 06:03
@gosha212 gosha212 merged commit 275fee9 into master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4vidi d4vidi d4vidi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scrollTo is not working as expected behavior on Android API 33 / 34 .scrollTo() gets stuck on Android
2 participants
@gosha212 @d4vidi