Add start position as an optional parameter to scrollTo action #4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-wix
requested review from
asafkorem,
d4vidi and
noomorph
as code owners
|
Great work @andrey-wix! 👑 Huge thanks!! |
asafkorem
requested review from
gosha212
and removed request for
noomorph and
d4vidi
asafkorem
requested changes
Dec 25, 2023
There was a problem hiding this comment.
Great work @andrey-wix! 🥇 🙌🏼
I have some small suggestions before we merge this 
detox/android/detox/src/full/java/com/wix/detox/espresso/DetoxAction.java
Outdated
Show resolved
Hide resolved
detox/android/detox/src/full/java/com/wix/detox/espresso/DetoxAction.java
Outdated
Show resolved
Hide resolved
detox/android/detox/src/main/java/com/wix/detox/espresso/scroll/ScrollHelper.java
Outdated
Show resolved
Hide resolved
noomorph
reviewed
Dec 27, 2023
andrey-wix
force-pushed
the
addStartPositionToScrollTo
branch
from
a357272 to
8adcf9b
Compare
…Action.java Co-authored-by: Asaf Korem <[email protected]>
…Action.java Co-authored-by: Asaf Korem <[email protected]>
…l/ScrollHelper.java Co-authored-by: Asaf Korem <[email protected]>
asafkorem
force-pushed
the
addStartPositionToScrollTo
branch
from
8adcf9b to
728d8b3
Compare
asafkorem
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
The build now passes after I rebased your branch (seems like it failed because it was outdated with recent changes on master).
Code LGTM 💯 Great work and thank you for this contribution @andrey-wix!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
scrollTo(edge)action API #3512In this pull request, I have …