Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix supervised android launch #4303

Merged
merged 6 commits into from
Dec 24, 2023
Merged

Fix supervised android launch #4303

merged 6 commits into from
Dec 24, 2023

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Dec 20, 2023

Description

  • This pull request addresses the issue described here: N/A

In this pull request, I have undone the reversion of #4293 - with an essential fix intact, to the following, formerly introduced, regression:

Whenever the test app is launched based on a URL (e.g. deep link), no user launch arguments (specified using the various Detox launch-args API's) are passed in (on Android).

The scope in this PR is therefore 2-fold:

  1. The original work of Re supervised android launch #4293, as-is.
  2. A fix for the aforementioned issue, alongside a new E2E test that covers this scenario (also involving some refactoring -- moving initial-URL tests onto a dedicated sub-screen), with a similar unit test around the previously impaired logic.

This results in the fact that as per code review, best to do so on a per-commit basis.

cc @evgeni-wix - should fix previously seen internal issues (i.e. broken external-link tests)


For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@d4vidi d4vidi requested review from noomorph and gosha212 December 20, 2023 13:22
@d4vidi d4vidi force-pushed the fix-supervised-android-launch branch from 0097fb7 to 5646532 Compare December 20, 2023 13:35
@d4vidi d4vidi force-pushed the fix-supervised-android-launch branch from 513f6af to 4650de8 Compare December 20, 2023 15:30
@d4vidi d4vidi merged commit 87d3db8 into master Dec 24, 2023
@d4vidi d4vidi deleted the fix-supervised-android-launch branch December 24, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants