Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): tap event on android API>31 #4216

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

ericschaal
Copy link
Contributor

@ericschaal ericschaal commented Oct 12, 2023

Description

In this pull request, I have updated obtainUpEvent in com.wix.detox.espresso.action.common.MotionEvent to match more closely the implementation of obtainUpEvent in androidx.test.espresso.action.MotionEvents.

For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@ericschaal ericschaal requested a review from d4vidi as a code owner October 12, 2023 15:09
@noomorph
Copy link
Collaborator

Thanks for your contribution!

Our Android guys are currently unavailable, but I'll try to review and suggest a test plan for this PR. It might take a few days.

Could you please tell me whether this PR should work with lower Android API versions? Did you have a chance to check both <=31 and >31?

@noomorph noomorph self-requested a review October 12, 2023 16:57
@ericschaal
Copy link
Contributor Author

Thanks for your contribution!

Our Android guys are currently unavailable, but I'll try to review and suggest a test plan for this PR. It might take a few days.

Could you please tell me whether this PR should work with lower Android API versions? Did you have a chance to check both <=31 and >31?

My thoughts are with everyone affected by the ongoing conflicts...

Thank you for taking a look despite the circumstances. I've tested the changes on both Android API versions 34 and 29. Please let me know if there's anything else you need.

@noomorph
Copy link
Collaborator

Okay, I see. If you don't mind, I'll create a prerelease tomorrow (in about 14-15 hours), and let's invite volunteers to give it a try.

I'll also try to run the pre-release on our mobile projects and see how it goes.

If no complaints are detected, we'll merge that after a week of dogfooding (next Thursday, for example).

@noomorph
Copy link
Collaborator

The smoke version is available as [email protected] on NPM.

@d4vidi
Copy link
Collaborator

d4vidi commented Oct 13, 2023

LGTM. Thank you.

@noomorph noomorph merged commit a71684a into wix:master Oct 17, 2023
@noomorph
Copy link
Collaborator

The fix is available in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants