Add duration of element.longPress for iOS #412

jhen0409 · 2017-11-16T14:33:27Z

Related to #410. I also added the test case Long Press Me 1.5s.

rotemmiz

Great PR! Thanks !
There are a few point I want to discuss before we merge it, please go over the notes.

rotemmiz · 2017-11-19T07:52:03Z

detox/src/ios/expect.js

    super();
-    this._call = invoke.callDirectly(GreyActions.actionForLongPress());
+    if (duration) {


let's add default value, drop the condition, and use only GreyActions.actionForLongPressWithDuration

rotemmiz · 2017-11-19T07:54:20Z

detox/test/e2e/c-actions.js

@@ -17,13 +17,18 @@ describe('Actions', () => {
    await expect(element(by.text('Long Press Working!!!'))).toBeVisible();
  });

+  it(':ios: should long press with duration on an element', async () => {


I don't want to create more discrepancy between iOS and Android API, I'm willing to help you add Android support as well if you need help.

Yeah I also really want this feature can be supported for Android, if you could help will be great. Thanks. :)

rotemmiz · 2017-11-19T07:54:40Z

detox/test/e2e/c-actions.js

  it('should multi tap on an element', async () => {
    await element(by.id('UniqueId819')).multiTap(3);
    await expect(element(by.id('UniqueId819'))).toHaveText('Taps: 3');
  });

  it('should tap on an element at point', async () => {
-    await element(by.id('View7990')).tapAtPoint({x:180, y:140});
+    await element(by.id('View7990')).tapAtPoint({x:180, y:160});


Why was that changed ?

I added a button for new test case, so the UniqueId819 button position was changed.

DanielMSchmidt · 2017-11-20T05:43:16Z

generation/earl-grey/index.js

@@ -47,6 +47,7 @@ if (

 // Constants
 const SUPPORTED_TYPES = [
+  "CFTimeInterval",


🎉🎉🎉

jozan · 2018-01-25T07:19:30Z

How is this progressing? Can I help somehow? We pretty much need this feature for both platforms. :)

jozan · 2018-02-04T20:25:45Z

Alright, I started working on this feature based on this PR.

rotemmiz · 2018-02-04T20:31:04Z

@jozan, for Android?

jozan · 2018-02-05T17:03:31Z

For iOS, we need this feature eventually for Android as well but even getting iOS to work would be very nice. I tried to rebase to master but it did not work out of the box since lot has changed past three months especially in generation dir. Also, after rebase both longPress and longPress(duration) did not pass tests and failed to error from this line: https://github.com/wix/detox/blob/master/detox/ios/Detox/MethodInvocation.m#L225 where value i was 0. I don’t have time to debug further today.

…

On Sun, 4 Feb 2018 at 22.31, Rotem Mizrachi-Meidan ***@***.***> wrote: @jozan <https://github.com/jozan>, for Android? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#412 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAXsqY4PksoiZHmNxM3_YnH-F0mjDShOks5tRhONgaJpZM4QglCG> .

stale · 2018-03-22T17:22:48Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rotemmiz · 2018-03-22T17:24:50Z

Go away stale bot! Sorry for the huge delay. We have intention to merge this in.

LeoNatan · 2018-05-04T07:26:35Z

Any news on this PR? Let’s merge for iOS and then in the future add for Android?

rotemmiz · 2018-05-04T07:31:14Z

Yes, let's do it

LeoNatan · 2018-05-04T07:33:14Z

@jhen0409 Could you please merge master and see that tests are not broken?

jhen0409 · 2018-05-05T08:37:16Z

@LeoNatan 👌

LeoNatan · 2018-05-05T10:07:59Z

Thanks!

LeoNatan · 2018-05-05T10:08:40Z

@yershalom Jenkins is flaky, please look why.

LeoNatan

Thanks for this PR.

I saw some style changes. Any reason those are needed?

LeoNatan · 2018-05-05T10:15:11Z

detox/src/ios/expect.js

@@ -65,9 +65,9 @@ class TapAtPointAction extends Action {
 }

 class LongPressAction extends Action {
-  constructor() {
+  constructor(duration = 750) {


Why is the default 750? Is this what Earl Grey uses in the long press action?

I forgot the reason, but it should be 1000 for now.

Let's instead use the default. If no param is provided, let's call the current API, but if there is provided, let's call the new API.

jhen0409 · 2018-05-05T11:17:26Z

The some style changes caused by Prettier, I reverted it.

LeoNatan · 2018-05-05T11:31:20Z

Cool. Let’s wait for the CI and I’ll merge. Thank you for your contribution!

jhen0409 force-pushed the longpress-duration branch 2 times, most recently from 6409603 to ec50f11 Compare November 16, 2017 16:18

rotemmiz reviewed Nov 19, 2017

View reviewed changes

jhen0409 force-pushed the longpress-duration branch 3 times, most recently from 5984004 to 0f18872 Compare November 19, 2017 13:55

DanielMSchmidt reviewed Nov 20, 2017

View reviewed changes

stale bot added the 🏚 stale label Mar 22, 2018

stale bot removed the 🏚 stale label Mar 22, 2018

jhen0409 requested a review from LeoNatan as a code owner May 5, 2018 08:10

LeoNatan reviewed May 5, 2018

View reviewed changes

Add duration arg for element.longPress

2948cfe

jhen0409 force-pushed the longpress-duration branch from 694e7ed to 996eb24 Compare May 5, 2018 11:17

LeoNatan approved these changes May 5, 2018

View reviewed changes

jhen0409 force-pushed the longpress-duration branch from 996eb24 to 5f1b6b0 Compare May 5, 2018 12:34

Update documentation for longPress(duration)

72233dc

jhen0409 force-pushed the longpress-duration branch from 5f1b6b0 to 72233dc Compare May 6, 2018 02:00

LeoNatan merged commit 21f9a75 into wix:master May 6, 2018

wix locked and limited conversation to collaborators Jul 23, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add duration of element.longPress for iOS #412

Add duration of element.longPress for iOS #412

jhen0409 commented Nov 16, 2017

rotemmiz left a comment

rotemmiz Nov 19, 2017

rotemmiz Nov 19, 2017

jhen0409 Nov 19, 2017

rotemmiz Nov 19, 2017

jhen0409 Nov 19, 2017

rotemmiz Nov 19, 2017

DanielMSchmidt Nov 20, 2017

jozan commented Jan 25, 2018

jozan commented Feb 4, 2018 •

edited

Loading

rotemmiz commented Feb 4, 2018

jozan commented Feb 5, 2018 via email

stale bot commented Mar 22, 2018

rotemmiz commented Mar 22, 2018

LeoNatan commented May 4, 2018

rotemmiz commented May 4, 2018

LeoNatan commented May 4, 2018

jhen0409 commented May 5, 2018

LeoNatan commented May 5, 2018

LeoNatan commented May 5, 2018

LeoNatan left a comment

LeoNatan May 5, 2018

jhen0409 May 5, 2018

LeoNatan May 5, 2018

jhen0409 commented May 5, 2018

LeoNatan commented May 5, 2018

Add duration of element.longPress for iOS #412

Add duration of element.longPress for iOS #412

Conversation

jhen0409 commented Nov 16, 2017

rotemmiz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jozan commented Jan 25, 2018

jozan commented Feb 4, 2018 • edited Loading

rotemmiz commented Feb 4, 2018

jozan commented Feb 5, 2018 via email

stale bot commented Mar 22, 2018

rotemmiz commented Mar 22, 2018

LeoNatan commented May 4, 2018

rotemmiz commented May 4, 2018

LeoNatan commented May 4, 2018

jhen0409 commented May 5, 2018

LeoNatan commented May 5, 2018

LeoNatan commented May 5, 2018

LeoNatan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jhen0409 commented May 5, 2018

LeoNatan commented May 5, 2018

jozan commented Feb 4, 2018 •

edited

Loading