Implemented AttachedAndroidDriver device for connecting to Genymotion #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotemmiz
reviewed
Nov 12, 2017
| constructor(client) { | ||
| super(client); | ||
|
|
||
| this.aapt = new AAPT(); |
There was a problem hiding this comment.
I just found out AAPT was in EmulatorDriver and not in AndroidDriver, pushed a change, please remove it as well.
| } | ||
|
|
||
| async acquireFreeDevice(name) { | ||
| const adbDevices = await this.adb.devices(); |
There was a problem hiding this comment.
This is an almost exact copy of the logic in EmulatorDriver (and we hate duplicate code of course 😬 ) . Why not merge in into a utility function inside AndroidDriver ?
| @@ -58,7 +58,19 @@ All Core APIs are 100% implemented. | |||
| ## Emulator control | |||
| 1. **Emulators** are fully supported, to choose an emulator to run your tests on check `emulator -list-avds`. If none exist, create one. | |||
| 2. **Devices** - Coming soon! | |||
| 3. **Genymotion** - Coming a bit later... | |||
There was a problem hiding this comment.
This does not relate to Genymotion specifically, it can be used with any connected android device, I think it should be emphesized in the docs.
|
Thanks for this great PR! |
|
Updated, please review. |
rotemmiz
approved these changes
Nov 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #386 and in #96 (comment) , I've implemented AttachedAndroidDriver (really a cut version of EmulatorDriver) that is able to connect to Genymotion and other adb-attached devices.
Also updated doc. Not sure if a test required.