Reimplemented SimulatorLogPlugin to use log stream #1428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The existing
SimulatorLogPlugin
implementation appears to be not informative (does not include various NSLog messages, etc) and hacky (relies on tailing two temporary files which contain piped output from a simulator launched in a special way).The suggested reimplementation is based on two extra commands:
, where the predicate is built via:
and looks like:
Ultimately, the plugin now is able to produce logs like these:
That should be helpful in troubleshooting various issues, including the one that blocks us from merging dinstruments-demoapp branch to master.