Fix issues related to single-task activities #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotemmiz
reviewed
Jan 23, 2019
d4vidi
force-pushed
the
android-fix-single-task
branch
2 times, most recently
from
4c395b7 to
06f561f
Compare
|
On 2nd thought, I could have an idea on how to get rid of |
d4vidi
force-pushed
the
android-fix-single-task
branch
2 times, most recently
from
31e3132 to
9a39d61
Compare
rotemmiz
reviewed
Jan 24, 2019
rotemmiz
requested changes
Jan 24, 2019
d4vidi
force-pushed
the
android-fix-single-task
branch
2 times, most recently
from
11898c6 to
d4eb1af
Compare
d4vidi
force-pushed
the
android-fix-single-task
branch
from
d4eb1af to
d9e8a2e
Compare
|
♨️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Address the problem specified in #1125.
The root cause resides in what appears to be an Espresso bug (still need to validate this). This PR introduces a workaround, along with associated improvements around the current confusion the android driver currently has around activities launching. I suppose that can be further improved, but one step at a time.