refactor(android): extract parser from for-loop.

wix · Sep 11, 2023 · e909dc1 · e909dc1
1 parent fec6fea
commit e909dc1
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/detox/android/detox/src/full/java/com/wix/invoke/types/Invocation.java b/detox/android/detox/src/full/java/com/wix/invoke/types/Invocation.java
@@ -92,9 +92,9 @@ public void setArgs(JSONArray args) throws JSONException {
                     } else if (type.equals("boolean")) {
                         argument = jsonArgument.optBoolean("value");
                     } else if (type.equals("Invocation")) {
-                        argument = new Invocation(jsonArgument.optJSONObject("value"));                        
+                        argument = new Invocation(jsonArgument.optJSONObject("value"));
                     } else {
-                        throw new RuntimeException("Unhandled arg type" + type);
+                        throw new RuntimeException("Unhandled arg type " + type);
                     }
                 }
             }
@@ -105,6 +105,8 @@ public void setArgs(JSONArray args) throws JSONException {
     }
 
     public void setArgs(Object[] args) {
+        JsonParser parser = new JsonParser();
+
         for (int i = 0; i < args.length; i++) {
             Object argument = args[i];
             if (argument instanceof HashMap && !((HashMap) argument).isEmpty()) {
@@ -125,10 +127,9 @@ public void setArgs(Object[] args) {
                 } else if (type.equals("boolean")) {
                     argument = ((Boolean) value).booleanValue();
                 } else if (type.equals("Invocation")) {
-                    JsonParser parser = new JsonParser();
                     argument = parser.parse((String)value);
                 } else {
-                    throw new RuntimeException("Unhandled arg type" + type);
+                    throw new RuntimeException("Unhandled arg type " + type);
                 }
 
                 args[i] = argument;