Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade for react-native 0.48 & react 16 #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jackdclark
Copy link

@jackdclark jackdclark commented Aug 18, 2017

change from using React.PropTypes to prop-types module
@timrc
Copy link

timrc commented Sep 4, 2017

Please merge this PR, it's annoying to see that warning :)

@jackdclark
Copy link
Author

@artald don't suppose you've had a chance to look at this one?

@brunolemos
Copy link

It crashes on iOS RN 48, couldn't we include a fix for that too? #31

@jackdclark jackdclark changed the title Upgrade for react-native 0.47 & react 16 Upgrade for react-native 0.48 & react 16 Sep 11, 2017
"react": "16.0.0-alpha.6",
"react-native": "0.44.2",
"react": "^16.0.0-alpha.12",
"react-native": "^0.47.1",
Copy link

@brunolemos brunolemos Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^0.48.2

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @brunolemos

@brunolemos
Copy link

cc @artald could you make a new npm release? thank you

@prscX
Copy link

prscX commented Oct 10, 2017

can you please merge this request, we are facing issue while using this library with rn-0.49

@@ -6,8 +6,8 @@
"start": "react-native start"
},
"dependencies": {
"react": "16.0.0-alpha.6",
"react-native": "0.44.2",
"react": "^16.0.0-alpha.12",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't react & react-native be peerDeps?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasbento this is for the example project, not the main lib. They are peer dependencies in the root package.json.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't see that it was the example app package.json, my mistake.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasbento no problem, thanks for taking a review!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainers can you please merge this request, so that we can use this lib seamlessly on rn0.49 and above

@jimdebeer
Copy link

@artald come on this has been open scince august..

@ValentinBlokhin
Copy link

any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants