-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade for react-native 0.48 & react 16 #26
base: master
Are you sure you want to change the base?
Conversation
change from using React.PropTypes to prop-types module
Please merge this PR, it's annoying to see that warning :) |
@artald don't suppose you've had a chance to look at this one? |
It crashes on iOS RN 48, couldn't we include a fix for that too? #31 |
example/package.json
Outdated
"react": "16.0.0-alpha.6", | ||
"react-native": "0.44.2", | ||
"react": "^16.0.0-alpha.12", | ||
"react-native": "^0.47.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^0.48.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @brunolemos
cc @artald could you make a new npm release? thank you |
can you please merge this request, we are facing issue while using this library with rn-0.49 |
@@ -6,8 +6,8 @@ | |||
"start": "react-native start" | |||
}, | |||
"dependencies": { | |||
"react": "16.0.0-alpha.6", | |||
"react-native": "0.44.2", | |||
"react": "^16.0.0-alpha.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't react
& react-native
be peerDeps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucasbento this is for the example project, not the main lib. They are peer dependencies in the root package.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, didn't see that it was the example app package.json, my mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucasbento no problem, thanks for taking a review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintainers can you please merge this request, so that we can use this lib seamlessly on rn0.49 and above
@artald come on this has been open scince august.. |
any progress? |
React.PropTypes
toprop-types
module (see https://facebook.github.io/react/warnings/dont-call-proptypes.html)defaultProps
to astatic
node_modules/
to.gitignore