Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet is using internal addresses in a non-sequential way #2384

Closed
aesedepece opened this issue Jul 11, 2023 · 1 comment · Fixed by #2385
Closed

Wallet is using internal addresses in a non-sequential way #2384

aesedepece opened this issue Jul 11, 2023 · 1 comment · Fixed by #2385
Labels
bug 🐜 Something isn't working wallet 👛 Issues related to witnet_wallet crate.

Comments

@aesedepece
Copy link
Member

aesedepece commented Jul 11, 2023

I recently found out that most of my wallets have enormous gaps in their internal keychains. For example, there's this one wallet whose only internal address in use are 168, 171 and 178.

The impact of this is:

  • [Mild] slightly slower sync in Sheikah
  • [Severe] missing balance when the same key is imported into myWitWallet
@aesedepece aesedepece added bug 🐜 Something isn't working wallet 👛 Issues related to witnet_wallet crate. labels Jul 11, 2023
@aesedepece
Copy link
Member Author

Found out that this is related to fee estimation. Apparently, the pointer to the next internal address index is being updated upon issuing an estimate — which shouldn't!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐜 Something isn't working wallet 👛 Issues related to witnet_wallet crate.
Projects
None yet
1 participant