fix(wallet): allow generating transactions without persisting change addresses #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesedepece
commented
Jul 11, 2023
| ) -> Result<Arc<model::Address>> { | ||
| let keychain = constants::INTERNAL_KEYCHAIN; | ||
| let account = state.account; | ||
| let index = state.next_internal_index; | ||
| let parent_key = &state.keychains[keychain as usize]; | ||
|
|
||
| let (address, next_index) = | ||
| self.derive_and_persist_address(label, parent_key, account, keychain, index, true)?; | ||
| self.derive_and_persist_address(label, parent_key, account, keychain, index, !preview)?; |
There was a problem hiding this comment.
This is the key point here. This will avoid persisting the change address if the transaction is being generated solely for preview purposes (e.g. estimating fees).
|
For this functionality to actually make an impact, a similar change is needed on the Sheikah side, so the |
aesedepece
force-pushed
the
fix/wallet/sparse-internal-keychain
branch
from
56efa5d to
cdb646b
Compare
aesedepece
force-pushed
the
fix/wallet/sparse-internal-keychain
branch
3 times, most recently
from
90e2f3c to
46d9352
Compare
aesedepece
force-pushed
the
fix/wallet/sparse-internal-keychain
branch
3 times, most recently
from
8e740e3 to
46d9352
Compare
i.e. when processing a transaction that uses the next internal address
aesedepece
force-pushed
the
fix/wallet/sparse-internal-keychain
branch
from
46d9352 to
bd6c130
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opens up the possibility of creating transactions in a wallet without persisting change addresses, which is needed in the case of fee estimations.
Fix #2384