Skip to content
This repository has been archived by the owner on Oct 11, 2022. It is now read-only.

[Mobile v1] Thread Card improvements & styling #2869

Merged
merged 8 commits into from
Apr 17, 2018

Conversation

ArturKlajnerok
Copy link
Contributor

@ArturKlajnerok ArturKlajnerok commented Apr 15, 2018

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • mobile

Here are some improvements to properly display ThreadCard on mobile app.

  • Removed old Avatar code
  • Simple Avatar based on RN Image
  • Facepile with avatars lined up
  • Styled EmptyParticipantHead (overflowAmount) on Facepile
  • New thread pill marker
  • Updated ThreadItem layout and style
  • Updated Thread feed screen style to fill full screen

Latest Screenshot :
Thread Feed Screen

Parent Issue : https://github.com/withspectrum/spectrum/issues/2330

Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very great so far! 😍

Only missing piece I see in terms of styling right now is overlaying the participant heads on top of each other like we do on the website, I think that might be it? And maybe some of the new messages logic, not sure.

@brianlovin
Copy link
Contributor

This is looking good so far! There are a few color + padding changes we can make as we go, but overall this is exciting to see!

Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ship this for now since it's a big improvement already!

@mxstbr mxstbr merged commit 9078f41 into withspectrum:alpha Apr 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants