Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace copy/pasted ImageFunction with imported SchemaContext #775

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

delucis
Copy link
Member

@delucis delucis commented Sep 27, 2023

What kind of changes does this PR include?

  • Changes to Starlight code

Description

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: a34e290

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit a34e290
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6514b02adf94de00084ee832
😎 Deploy Preview https://deploy-preview-775--astro-starlight.netlify.app/de/guides/css-and-tailwind
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Sep 27, 2023
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Sep 27, 2023

size-limit report 📦

Path Size
/index.html 9.42 KB (0%)
/_astro/*.js 19.25 KB (0%)
/_astro/*.css 9.55 KB (0%)

@delucis
Copy link
Member Author

delucis commented Sep 27, 2023

Hmm, seems to make tests hang here and also locally. Not a great sign!

@delucis delucis closed this Sep 27, 2023
@delucis delucis deleted the experimental/import-astro-content branch September 27, 2023 20:31
@delucis delucis reopened this Sep 27, 2023
@delucis delucis marked this pull request as ready for review September 27, 2023 20:51
@delucis delucis added the 🌟 patch Change that triggers a patch release label Sep 27, 2023
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@delucis delucis merged commit 2ef3036 into main Sep 27, 2023
8 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Sep 27, 2023
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Sep 28, 2023
* main:
  Replace copy/pasted `ImageFunction` with imported `SchemaContext` (withastro#775)
@HiDeoo HiDeoo mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docsSchema typings conflict with defineCollection typings
3 participants