Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ko-KR): translate sidebar.mdx #663

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Conversation

jsparkdev
Copy link
Contributor

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

translate sidebar.mdx

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2023

⚠️ No Changeset found

Latest commit: 3c1c3a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 6, 2023

👷 Deploy Preview for astro-starlight processing.

Name Link
🔨 Latest commit 3c1c3a3
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/65038b7dbc3ebd0008214471

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Sep 6, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @jsparkdev! I noticed a few places where the “New” badge isn’t translated. That’s OK if it’s intentional, but I’d definitely translate the first on in the frontmatter so it shows up in the Starlight navigation in Korean.

docs/src/content/docs/ko/guides/sidebar.mdx Show resolved Hide resolved
docs/src/content/docs/ko/guides/sidebar.mdx Show resolved Hide resolved
docs/src/content/docs/ko/guides/sidebar.mdx Show resolved Hide resolved
@jsparkdev
Copy link
Contributor Author

The badge “New” is also used very frequently on various websites in South Korea.

So, I intentionally didn't translate the "New" badge.

If many other Koreans reading this document feel uncomfortable, I will think about revising it.

Thank you for your good comments and thorough review! @delucis 😊

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, great — that sounds good to me then! Thanks again for the translation and your patience waiting to get this merged 🙌

@delucis delucis merged commit 01b9ab5 into withastro:main Sep 14, 2023
@jsparkdev jsparkdev deleted the sidebar branch September 14, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants