-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds icon for phone #2726
Adds icon for phone #2726
Conversation
🦋 Changeset detectedLatest commit: 090f396 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, commented on the discussion before seeing there was a PR already. As noted in #2725 we can’t add this as a social option as those need to have accessible labels provided by Starlight. This works for social networks that have a consistent brand name across languages, but not for something like “phone” which would need a label that adapts to the current language.
Could you remove the social icon part from this PR so it is only adding the icon itself? That way people are still free to use the icon directly (and label it as they see fit).
@delucis - Thanks for the review and makes sense regarding social. I hadn't planned on including it in social since it's really not a "social" thing but noticed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🙌
And yeah, email
suffers from the same issue to be honest — I don’t think we’d fully thought through that policy at the time, so it snuck in. “E-mail” is a bit more common in various languages, but it still isn’t ideal for many. Guess that ship has sailed though 😅
Description