Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds icon for phone #2726

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Adds icon for phone #2726

merged 2 commits into from
Dec 19, 2024

Conversation

techfg
Copy link
Contributor

@techfg techfg commented Dec 18, 2024

Description

image

Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: 090f396

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 090f396
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67631ff6676d1c000892346c
😎 Deploy Preview https://deploy-preview-2726--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, commented on the discussion before seeing there was a PR already. As noted in #2725 we can’t add this as a social option as those need to have accessible labels provided by Starlight. This works for social networks that have a consistent brand name across languages, but not for something like “phone” which would need a label that adapts to the current language.

Could you remove the social icon part from this PR so it is only adding the icon itself? That way people are still free to use the icon directly (and label it as they see fit).

@techfg techfg changed the title Adds social link icon for phone Adds icon for phone Dec 18, 2024
@techfg
Copy link
Contributor Author

techfg commented Dec 18, 2024

@delucis -

Thanks for the review and makes sense regarding social. I hadn't planned on including it in social since it's really not a "social" thing but noticed email was in social so felt phone was similar and made sense. PR updated to remove :)

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

And yeah, email suffers from the same issue to be honest — I don’t think we’d fully thought through that policy at the time, so it snuck in. “E-mail” is a bit more common in various languages, but it still isn’t ideal for many. Guess that ship has sailed though 😅

@delucis delucis added the 🌟 patch Change that triggers a patch release label Dec 19, 2024
@delucis delucis merged commit e54ebd5 into withastro:main Dec 19, 2024
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants