Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list item spacing bug on Firefox #2717

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix list item spacing bug on Firefox #2717

merged 2 commits into from
Dec 17, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Dec 17, 2024

Description

  • Firefox renders margins applied to <br> unlike other browsers.

  • We had a style which unintentionally applied margin-bottom to <br> inside list items, which would cause odd spacing in lists only in Firefox. For example, in the Astro docs:

    unordered list with irregular spacing of items

  • This PR fixes this by excluding <br> from that style, and also adds <code> to avoid the same issue impacting list items with a last child that is an inline code element.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 17, 2024
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit c7478ce
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6761724d7daf4b0008e99e15
😎 Deploy Preview https://deploy-preview-2717--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

size-limit report 📦

Path Size
/index.html 6.93 KB (+0.02% 🔺)
/_astro/*.js 21.19 KB (0%)
/_astro/*.css 13.75 KB (-0.02% 🔽)

@delucis delucis added the 🌟 patch Change that triggers a patch release label Dec 17, 2024
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it's been a while since that issue came out 😅 Tested in Firefox and this is indeed fixed.

@delucis delucis merged commit c5fcbb3 into main Dec 17, 2024
16 checks passed
@delucis delucis deleted the chris/fix-markdown-style branch December 17, 2024 14:55
@astrobot-houston astrobot-houston mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants