-
-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make asides less prominent #2659
base: main
Are you sure you want to change the base?
Conversation
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
🦋 Changeset detectedLatest commit: 83118bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this and your other PRs @illright!
As a heads up, the changes proposed in #1701 were not 100% finalised/agreed upon, so a review may take a bit of time.
We’re currently focusing our efforts on getting the Astro v5-compatible release of Starlight ready, so please understand if it takes some time to get back to you on these.
Description
Related to #1701
This PR changes the appearance of aside blocks to make them stand out less. This was done by changing the
-low
version of the color palette to be less prominent. This change also affected the Card component.I based my changes off of HiDeoo's WIP branch, but left off some changes:
color-mix
to add transparency to existing-low
colors, I decided to change the low colors to keep consistencyScreenshots of the before/after for asides and cards in dark/light mode