Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix favicon support for query and fragment in URLs #2645

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Fix favicon support for query and fragment in URLs #2645

merged 6 commits into from
Dec 4, 2024

Conversation

techfg
Copy link
Contributor

@techfg techfg commented Nov 30, 2024

Description

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Nov 30, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 30, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 539b5d5
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6750b68b46b6330009df1d61
😎 Deploy Preview https://deploy-preview-2645--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 539b5d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

delucis
delucis reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @techfg! Left a few suggestions.

packages/starlight/utils/path.ts Outdated Show resolved Hide resolved
packages/starlight/utils/path.ts Outdated Show resolved Hide resolved
packages/starlight/utils/path.ts Outdated Show resolved Hide resolved
.changeset/neat-deers-pretend.md Outdated Show resolved Hide resolved
@techfg techfg mentioned this pull request Dec 4, 2024
Open
@techfg
Copy link
Contributor Author

techfg commented Dec 4, 2024

@delucis - Sorry again for my oversight regarding how URL constructor worked, incorrectly assumed it would fail if url was absolute and a base was also provided. I've updated PR per your comments although I eliminated the util function splitQueryAndFragment completely since it seemed unnecessary given the usage of URL constructor which I just used inline. Let me know if you have any future feedback, thanks!

delucis
delucis approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! And it’s much simpler now too. Great work 🙌

@delucis delucis added the 🌟 patch Change that triggers a patch release label Dec 4, 2024
@delucis delucis changed the title Fix favicon does not support query and fragment Fix favicon support for query and fragment in URLs Dec 4, 2024
@delucis delucis merged commit cf12beb into withastro:main Dec 4, 2024
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Dec 4, 2024
Merged
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Dec 13, 2024
@HiDeoo
Merge branch 'main' into hd-astro-v5
3f41484 
* main:
  [ci] release (withastro#2634)
  ci: update file icons (withastro#2663)
  i18n(ru): update ru.json (withastro#2642)
  Improve error message with invalid configuration (withastro#2656)
  docs: use single listener in icons reference (withastro#2657)
  fix: use seti ui repo to generate file icons (withastro#2648)
  Fix favicon support for query and fragment in URLs (withastro#2645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

favicon expects a relative url but treats it as a filename
2 participants
@techfg @delucis