Fix synced nested <Tabs>
restoration issue
#2377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes an issue reported on Discord regarding synced nested tabs.
Repro steps:
This issue is similar to #473 where the panels
hidden
property was not being set correctly due to the query selector matching all nested panels instead of just the direct children. The same issue can happen when restoring synced tabs as this part of the code was not including the same fix.The restoration code now also uses the
:scope
CSS pseudo-class to only match the direct children.I've included a test case to cover both the syncing of nested tabs (fixed in #473) and the restoration of synced nested tabs (fixed in this PR).
I also tested the fix locally on the Cloudflare docs and it now works as expected.