Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synced nested <Tabs> restoration issue #2377

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Sep 19, 2024

Description

This pull request fixes an issue reported on Discord regarding synced nested tabs.

Repro steps:

This issue is similar to #473 where the panels hidden property was not being set correctly due to the query selector matching all nested panels instead of just the direct children. The same issue can happen when restoring synced tabs as this part of the code was not including the same fix.

The restoration code now also uses the :scope CSS pseudo-class to only match the direct children.

I've included a test case to cover both the syncing of nested tabs (fixed in #473) and the restoration of synced nested tabs (fixed in this PR).

I also tested the fix locally on the Cloudflare docs and it now works as expected.

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: 33e0e4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Sep 19, 2024
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 33e0e4e
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66ec5b69aaf45200089ac4c7
😎 Deploy Preview https://deploy-preview-2377--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing so quickly @HiDeoo! Will get this released right away for folks 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants