Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable skipped navigation test #2329

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Re-enable skipped navigation test #2329

merged 2 commits into from
Sep 16, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Sep 16, 2024

Description

Copy link

changeset-bot bot commented Sep 16, 2024

⚠️ No Changeset found

Latest commit: 3519bb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Sep 16, 2024
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 3519bb1
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66e83fdeab1eec00083d5db4
😎 Deploy Preview https://deploy-preview-2329--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Sep 16, 2024

size-limit report 📦

Path Size
/index.html 6.15 KB (0%)
/_astro/*.js 22.36 KB (0%)
/_astro/*.css 13.72 KB (0%)

@delucis
Copy link
Member Author

delucis commented Sep 16, 2024

Ah, the snapshot change is actually unexpected — will need to work out why.

Edit: snapshot was correct, fixed the test code itself instead 👍

Starlight does the equivalent of getSidebar(Astro.url.pathname) in real-world usage, so in the scenario this test was emulating getSidebar('/index.html') was the expected usage.

@delucis delucis changed the title Re-enable skipped navigation test and fix snapshot Re-enable skipped navigation test Sep 16, 2024
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense, thanks for fixing so quickly 🙌

@delucis delucis merged commit bf93994 into main Sep 16, 2024
15 checks passed
@delucis delucis deleted the chris/fix-skipped-test branch September 16, 2024 14:33
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Sep 16, 2024
* main: (27 commits)
  Re-enable skipped navigation test (withastro#2329)
  docs(showcase): add Open {re}Source website (withastro#2324)
  i18n(es): update `manual-setup` & `configuration` (withastro#2317)
  i18n(es): update `css-and-tailwind` (withastro#2311)
  i18n(es): update `components` (withastro#2310)
  i18n(es): update `frontmatter` (withastro#2318)
  i18n(es): update `plugins` (withastro#2319)
  i18n(es): update `pages` (withastro#2314)
  i18n(es): update `site-search` (withastro#2315)
  [ci] format
  i18n(es): update `index` (withastro#2316)
  i18n(es): add `authoring-content` (withastro#2320)
  i18n(es): update `customization` (withastro#2312)
  i18n(fr): update `reference/configuration` (withastro#2308)
  i18n(ru): update `ru/manual-setup.mdx` and `ru/reference/configuration.mdx` (withastro#2307)
  [ci] format
  i18n(ru): update some guides (withastro#2306)
  i18n(fr): update `manual-setup` (withastro#2299)
  i18n(fr): update `guides/pages` (withastro#2298)
  [ci] release (withastro#2304)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants