Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publishing E2E tests #2250

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Stop publishing E2E tests #2250

merged 2 commits into from
Sep 2, 2024

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Aug 21, 2024

Description

This PR adds E2E tests and their configuration to the .npmignore file to avoid publishing them:

image

I tested the change before and after with pnpm publish --dry-run --no-git-checks in the packages/starlight/ directory and confirmed that the E2E tests are no longer included after this change.

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 3d008bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 3d008bf
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66c623ca6875870008c394f8
😎 Deploy Preview https://deploy-preview-2250--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch — thanks @HiDeoo! This probably needs a changeset so we can release it?

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again — end-to-end, but not end-to-end-to-npm 🚀

@delucis delucis merged commit c0a6166 into withastro:main Sep 2, 2024
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants