Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kudos option to add “Built with Starlight” badge to site footers #1958

Merged
merged 14 commits into from
Jun 5, 2024
Merged

Add kudos option to add “Built with Starlight” badge to site footers #1958

merged 14 commits into from
Jun 5, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Jun 5, 2024

Description

  • Adds a new config option to enable a “Built with Starlight” badge in the footer of your site

@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jun 5, 2024 5:29pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
starlight-i18n ⬜️ Ignored (Inspect) Jun 5, 2024 5:29pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: e8c3d38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Jun 5, 2024
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Jun 5, 2024 •
edited
Loading

size-limit report 📦

Path Size
/index.html 5.79 KB (-0.04% 🔽)
/_astro/*.js 21.95 KB (+0.61% 🔺)
/_astro/*.css 13.62 KB (+0.34% 🔺)

@github-actions github-actions bot added the 📚 docs Documentation website changes label Jun 5, 2024
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Jun 5, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/configuration.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

delucis and others added 2 commits June 5, 2024 18:43
@delucis @HiDeoo
@florian-lefebvre @sarah11918
Translate French label
174939d 
Co-Authored-By: HiDeoo <[email protected]>
Co-Authored-By: Florian Lefebvre <[email protected]>
Co-Authored-By: Sarah Rainsberger <[email protected]>
delucis and others added 2 commits June 5, 2024 18:50
@delucis @liruifengv
Translate zh-cn label
580331a 
Co-Authored-By: liruifengv <[email protected]>
@delucis @Adammatthiesen
Translate nb label
71d3ac6 
Co-Authored-By: Adam Matthiesen <[email protected]>
@kevinzunigacuellar
Copy link
Member

:cheffkiss:

Adammatthiesen
Adammatthiesen approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@Adammatthiesen Adammatthiesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastisk arbeid! Gratulerer med dagen Starlight!

sarah11918
sarah11918 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy Birthday, Starlight! 🌟

jdtjenkins
jdtjenkins reviewed Jun 5, 2024
View reviewed changes
packages/starlight/components/Footer.astro
.meta {
gap: 0.75rem 3rem;
justify-content: space-between;
flex-wrap: wrap;
margin-block: 3rem 1.5rem;
margin-top: 3rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we want to change this to margin-block-start instead of margin-top?

HiDeoo
HiDeoo approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect live stream collab and amazing work 👏

jdtjenkins
jdtjenkins approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@jdtjenkins jdtjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

trueberryless
trueberryless suggested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thx @sarah11918. Without you I couldn't have done this suggestion...

packages/starlight/translations/de.json Outdated Show resolved Hide resolved
@delucis delucis added the 🌟 minor Change that triggers a minor release label Jun 5, 2024
@Fryuni
Copy link
Member

Fryuni commented Jun 5, 2024

Gotta give credit where credit is due

lorenzolewis
lorenzolewis approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@lorenzolewis lorenzolewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@delucis delucis merged commit 081d1a9 into main Jun 5, 2024
12 checks passed
@delucis delucis deleted the chris/hbdsl branch June 5, 2024 17:30
@astrobot-houston astrobot-houston mentioned this pull request Jun 5, 2024
Merged
thomasbnt added a commit to thomasbnt/starlight that referenced this pull request Jun 5, 2024
@thomasbnt
i18n(fr): Update reference/configuration.mdx from withastro#1958
83e833f
@thomasbnt thomasbnt mentioned this pull request Jun 5, 2024
Merged
@huyikai huyikai mentioned this pull request Jun 6, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Jun 6, 2024
Merged
This was referenced Jun 27, 2024
Open
Open
Open
@wqyeo wqyeo mentioned this pull request Jul 10, 2024
Open
This was referenced Oct 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueberryless trueberryless trueberryless requested changes

@Adammatthiesen Adammatthiesen Adammatthiesen approved these changes

@BryceRussell BryceRussell BryceRussell approved these changes

@lorenzolewis lorenzolewis lorenzolewis approved these changes

@Fryuni Fryuni Fryuni approved these changes

@jdtjenkins jdtjenkins jdtjenkins approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes 🌟 minor Change that triggers a minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.