Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(zh-cn): Update some docs about #1620 & #1613 #1835

Merged
merged 2 commits into from
May 8, 2024
Merged

i18n(zh-cn): Update some docs about #1620 & #1613 #1835

merged 2 commits into from
May 8, 2024

Conversation

liruifengv
Copy link
Member

@liruifengv liruifengv commented May 7, 2024 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b59adbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview May 8, 2024 6:57am

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels May 7, 2024
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented May 7, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
zh-cn guides/i18n.mdx Localization changed, will be marked as complete.
zh-cn guides/pages.mdx Localization changed, will be marked as complete.
zh-cn reference/configuration.mdx Localization changed, will be marked as complete.
zh-cn reference/frontmatter.md Localization changed, will be marked as complete.
zh-cn reference/overrides.md Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

huyikai
huyikai reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@huyikai huyikai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

HiDeoo
HiDeoo approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation and the extra review 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist and everything looks good to me too 👍

@HiDeoo HiDeoo merged commit 2bbed1b into withastro:main May 8, 2024
12 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request May 8, 2024
@HiDeoo
Merge branch 'main' into hd-refactor-astro-i18n
c193d55 
* main:
  i18n(zh-cn): Update docs about synced-tabs (withastro#1834)
  i18n(zh-cn): Update some docs about withastro#1620 & withastro#1613 (withastro#1835)
  Add more diagnostic help to error messages thrown by `<Steps>` (withastro#1838)
  i18n(zh-cn): Update components.mdx (withastro#1836)
  i18n(zh-cn): Update community-content.mdx (withastro#1833)
  Improve type checking job (withastro#1831)
  [ci] format
  [ci] release (withastro#1832)
  i18n(ru): update ru.json (withastro#1826)
  Fix `<Tabs>` sync issue with inconsistent use of `icon` on `<TabItem>` components (withastro#1811)
  Enable `BASE_URL` tests (withastro#1828)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyikai huyikai huyikai left review comments

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liruifengv @astrobot-houston @HiDeoo @huyikai