-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds print styles for Starlight docs pages #157
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 20cf394 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
2289ff4
to
f455c1c
Compare
57d6c69
to
819ea02
Compare
@delucis thoughts on whether this feature is worth merging or should I close it? I'm still a bit torn on the increase in bundled CSS versus pulling all print styles out to a global |
I think my preference is likely for pulling this out to a separate global file to avoid extra downloads. (We’d need a I am a bit torn because as you highlighted, that does come with extra maintenance complexity. Especially as this is exactly the kind of thing we’re likely to forget to check as we add stuff 😅 That said, most stuff is done pretty safely via (There’s a chance even doing that will fail the CI check here — it’s a bit of a rough tool at the moment, just globbing Let me know if you’re happy doing that or if you’d prefer me to tackle! |
@delucis Yep that's no problem, I'll refactor that this morning and pull the styles out into a global sheet 👍 |
@delucis done! Everything is moved out to the separate Looks like the HTML size-limit is failing by ~1kb, that should just be from the extra |
Best laid plans! It turns out there isn't currently a great way to get around the CSS being inlined there, I'm going to close this out for now as blocked. @delucis, @bluwy, and I were catching up on Discord and it sounds like this may be worthy of a feature in Vite to be able to |
Will need to wait on withastro/astro#12758 to use the |
What kind of changes does this PR include?
Description