Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(fr): Update guides/components and getting-started #1506

Merged
merged 22 commits into from
Feb 18, 2024
Merged

i18n(fr): Update guides/components and getting-started #1506

merged 22 commits into from
Feb 18, 2024

Conversation

thomasbnt
Copy link
Member

Description

Update guides/components and getting-started in french language.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 56c7961

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 18, 2024 4:33pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 17, 2024
HiDeoo
HiDeoo requested changes Feb 17, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌 I left a few suggestions but nothing major, this is looking pretty good to me!

While reviewing these changes, I noticed that the original French translation of the "Authoring Content in Markdown" guide did not translate "aside". Would you be up to make a new PR to update and polish the "asides" section in this guide so we can have a consistent translation between the two pages?

docs/src/content/docs/fr/getting-started.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/components.mdx Outdated Show resolved Hide resolved
@thomasbnt
Copy link
Member Author

Thanks for the translation 🙌 I left a few suggestions but nothing major, this is looking pretty good to me!

While reviewing these changes, I noticed that the original French translation of the "Authoring Content in Markdown" guide did not translate "aside". Would you be up to make a new PR to update and polish the "asides" section in this guide so we can have a consistent translation between the two pages?

I hesited to change Aside by Encarts in french, but Aside and best known in web development.

thomasbnt and others added 8 commits February 17, 2024 17:56
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/components.mdx
c23202d 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/components.mdx
95a1980 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/components.mdx
4ba7431 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/components.mdx
3509d8e 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/components.mdx
8b17d8c 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/components.mdx
fad8b6c 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/components.mdx
e5d9f81 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/components.mdx
ad7703c 
Co-authored-by: HiDeoo <[email protected]>
@thomasbnt
Copy link
Member Author

Thanks again @HiDeoo, I edited the file with your review. I updated authoring-content file for "Asides" -> "Encarts"

HiDeoo
HiDeoo requested changes Feb 18, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and also taking the time to address the suggested changes in the authoring content guide.

I left a few suggestions but they're very minor and we should be able to merge this soon 🚀

I also noted your concern about losing the "aside" reference so I left a suggestion to keep it so it can still be easily found using this keyword while still correctly translating it.

docs/src/content/docs/fr/getting-started.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/components.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/authoring-content.md Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/authoring-content.md Outdated Show resolved Hide resolved
docs/src/content/docs/fr/guides/authoring-content.md Outdated Show resolved Hide resolved
HiDeoo
HiDeoo approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks again for the translations and updates 🙌 Let's merge this in!

@HiDeoo HiDeoo merged commit 74169cd into withastro:main Feb 18, 2024
9 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 20, 2024
@HiDeoo
Merge branch 'main' into hd-file-tree
7e91fb8 
* main: (34 commits)
  i18n(ja): Update customization.mdx (withastro#1526)
  [ci] format
  i18n(zh-cn): Update manual-setup.mdx (withastro#1522)
  i18n(zh-cn): Update community-content.mdx (withastro#1520)
  Add Astro-GhostCMS to showcase (withastro#1529)
  [ci] format
  i18n(zh-cn): Update components.mdx (withastro#1513)
  i18n(zh-cn): Update getting-started.mdx (withastro#1510)
  [ci] format
  i18n(zh-cn): Translate pages.mdx (withastro#1523)
  i18n(ja): Add pages.mdx (withastro#1524)
  [ci] format
  i18n(fr): Update `guides/components` and `getting-started` (withastro#1506)
  i18n(ja): Update components.mdx (withastro#1514)
  i18n(ja): Update sidebar.mdx (withastro#1511)
  i18n(ja): Update configuration.mdx (withastro#1515)
  i18n(ja): Update getting-started.mdx (withastro#1507)
  i18n(ja): Update site-search.mdx (withastro#1512)
  i18n(ja): Add showcase.mdx (withastro#1516)
  i18n(ja): Add plugins.mdx (withastro#1519)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasbnt @HiDeoo