New installation of starlight causing infinite loop

[pierskarsenbarg]

What version of starlight are you using?

0.30.3

What version of astro are you using?

5.1.0

What package manager are you using?

npm

What operating system are you using?

Mac

What browser are you using?

chrome

Describe the Bug

Brand new installation of astro with starlight:

npm create astro@latest -- --template starlight

Ran npm run dev and opened page in browser

Page didn't load but console showed this in an infinite loop:

ERROR] [UnhandledRejection] Astro detected an unhandled rejection. Here's the stack trace:
ShikiError: Language `(define name)` is not included in this bundle. You may want to load it from external source.
    at resolveLang (file:///Users/piers/go/src/github.com/pierskarsenbarg/astro-starlight-docker/node_modules/@shikijs/core/dist/index.mjs:1874:17)
    at file:///Users/piers/go/src/github.com/pierskarsenbarg/astro-starlight-docker/node_modules/@shikijs/core/dist/index.mjs:1891:52
    at Array.map (<anonymous>)
    at createHighlighter (file:///Users/piers/go/src/github.com/pierskarsenbarg/astro-starlight-docker/node_modules/@shikijs/core/dist/index.mjs:1891:41)
    at getSingletonHighlighter (file:///Users/piers/go/src/github.com/pierskarsenbarg/astro-starlight-docker/node_modules/@shikijs/core/dist/index.mjs:1914:16)
    at codeToHtml (file:///Users/piers/go/src/github.com/pierskarsenbarg/astro-starlight-docker/node_modules/@shikijs/core/dist/index.mjs:1938:27)
    at getViteErrorPayload (file:///Users/piers/go/src/github.com/pierskarsenbarg/astro-starlight-docker/node_modules/astro/dist/core/errors/dev/vite.js:88:48)
    at Timeout._onTimeout (file:///Users/piers/go/src/github.com/pierskarsenbarg/astro-starlight-docker/node_modules/astro/dist/vite-plugin-astro-server/response.js:19:67)
    at listOnTimeout (node:internal/timers:573:17)
    at process.processTimers (node:internal/timers:514:7)
  Hint:
    Make sure your promises all have an `await` or a `.catch()` handler.
  Error reference:
    https://docs.astro.build/en/reference/errors/unhandled-rejection/
  Stack trace:
    at resolveLang (file:///Users/piers/go/src/github.com/pierskarsenbarg/astro-starlight-docker/node_modules/@shikijs/core/dist/index.mjs:1874:17)
    at Array.map (<anonymous>)
    [...] See full stack trace in the browser, or rerun with --verbose.

Link to Minimal Reproducible Example

https://github.com/pierskarsenbarg/astro-starlight-shiki-bug

Participation

• I am willing to submit a pull request for this issue.

[HiDeoo]

Thanks for the report 🙌

This seems to be a duplicate of withastro/astro#12796 which indicates an upstream issue with esbuild. Looks like Vite already released a fix by pinning the esbuild version and a PR on Astro has been opened too to update to this version.

I suggest following the linked Astro issue to track progress in the meantime.

[pierskarsenbarg]

@HiDeoo is this going to be the same for #2734 ?

For this issue (#2733) I'm not seeing the same ShikiError error on a new installation of Astro with the basic template (https://github.com/pierskarsenbarg/astro-new-template) hence why I created this issue here rather than the main astro repo

[pierskarsenbarg]

Ignore that comment - I can see that the reporter of that issue said that the basic template was fine as well.

Thanks