Fixes ToC highlighting after window resize (#2507)

withastro · Oct 25, 2024 · bd6ced5 · bd6ced5
1 parent 46907fb
commit bd6ced5
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/silent-fireants-retire.md b/.changeset/silent-fireants-retire.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/starlight': patch
+---
+
+Fixes a table of contents highlighting issue after resizing the window.
diff --git a/packages/starlight/components/TableOfContents/starlight-toc.ts b/packages/starlight/components/TableOfContents/starlight-toc.ts
@@ -88,7 +88,10 @@ export class StarlightTOC extends HTMLElement {
 		let timeout: NodeJS.Timeout;
 		window.addEventListener('resize', () => {
 			// Disable intersection observer while window is resizing.
-			if (observer) observer.disconnect();
+			if (observer) {
+				observer.disconnect();
+				observer = undefined;
+			}
 			clearTimeout(timeout);
 			timeout = setTimeout(() => this.onIdle(observe), 200);
 		});

diff --git a/packages/starlight/vitest.config.ts b/packages/starlight/vitest.config.ts
@@ -21,10 +21,10 @@ export default defineConfig({
 			],
 			thresholds: {
 				autoUpdate: true,
-				lines: 89.28,
+				lines: 89.26,
 				functions: 92.78,
 				branches: 92.83,
-				statements: 89.28,
+				statements: 89.26,
 			},
 		},
 	},