Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseJS will now ignore JSON scripts #669

Merged

Conversation

goulvenclech
Copy link
Contributor

Fix #513

Changes

  • parseJS will now ignore JSON scripts, including both MIME JSON types and importmap and speculationrules script types

Testing

  • Add a test "Ignore JSON scripts" in packages/language-server/test/units/parseJS.test.ts

Docs

N/A

@goulvenclech goulvenclech requested a review from a team as a code owner October 24, 2023 12:39
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: 7d5f9c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/language-server Patch
astro-vscode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@Princesseuh Princesseuh merged commit 0e9861e into withastro:main Oct 24, 2023
@goulvenclech goulvenclech deleted the fix/jsparse-ignore-json-scripts branch October 25, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: LD+JSON throws errors in .astro template
2 participants