-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added icon to language #186
Conversation
🦋 Changeset detectedLatest commit: 308cda8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I've taken the icon from here: vscode-icons/vscode-icons#2774 |
The viewbox property has a different value. Maybe using the original size (32x32) will fix it? |
@Princesseuh I've updated the icon, try now |
Ok, I've found this icon, maybe this one works |
Unfortunately, same thing with that one haha. Does it work fine on your side? Maybe it's an issue with my particular setup |
I can replicate it but I don't know how to fix it. In only happens with the Seti theme, so maybe we could submit an icon there (?) |
It seems that we aren't the only ones with alignment issues: microsoft/vscode#141335 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO a misaligned icon is better than no icon! I'd merge this and we can fix the alignment later?
@natemoo-re Let me do a quick try by removing the margins with figma. If it stays the same, I'll merge it |
Plot twist: it didn't work |
Changes
Testing
Docs