Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document decoding of params #9497

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Sep 26, 2024

Description (required)

This PR documents a new behaviour that changed in Astro v5

For Astro version: 5.x. See astro PR #12079.

@ematipico ematipico added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. 5.0 For 5.0 stable release labels Sep 26, 2024
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit c53aa7f
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66fe9a2c8e073d0008083cfe
😎 Deploy Preview https://deploy-preview-9497--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience @ematipico !

I made some tiny edits, and in both cases move the position of the content (so it's closer to the SSG/getStaticPaths stuff in the routing guide, and with the main Astro changes, not the other APIs, in the upgrade guide.

Please review to check on this, then you are happy and the feature is released, it's fine to merge!

@ematipico ematipico merged commit ce89532 into 5.0.0-beta Oct 3, 2024
5 checks passed
@ematipico ematipico deleted the change/astro-params branch October 3, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0.0-beta add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants