-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server islands #9255
Server islands #9255
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Updated comment: After speaking with Fred, I think we do want this on a page in the routing section. So, am starting to redraft a secondary page to see what it would look like with that focus. |
…to server-islands
|
||
### Benefits of server islands | ||
|
||
The most obvious benefit of server islands is the ability to render the more highly dynamic parts of your page on the fly. This allows the outer shell and main content to be more aggressively cached, providing faster performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most obvious benefit of server islands is the ability to render the more highly dynamic parts of your page on the fly. This allows the outer shell and main content to be more aggressively cached, providing faster performance. | |
Server islands is the ability to render the more highly dynamic parts of your page on the fly, leaving the outer shell and main content to be more aggressively cached, providing faster performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the push back I'd give here is that we don't really need to redefine server islands at this point. This section is about the benefits, and it should probably start like the client island section does, which is exactly this "The most obvious benefit".
Instead of removing that, if you had to fill in the blank to finish that (or a similar sentence), what would you say?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, here's a few of my nits/thoughts 🙌
Co-authored-by: Yan <[email protected]>
Description (required)
This includes:
For Astro version:
5.x
.