Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server islands #9255

Merged
merged 25 commits into from
Sep 12, 2024
Merged

Server islands #9255

merged 25 commits into from
Sep 12, 2024

Conversation

matthewp
Copy link
Contributor

Description (required)

This includes:

  • Updates to the directives reference page.
  • Server islands guide
    • Note that this guide could also be a section of the Astro components page. It's longer than any section on that page, however. So it could also be linked to from that page and that's how you get to it.

For Astro version: 5.x.

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit dc6dde8
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66e32ba73c3af900075b1c29
😎 Deploy Preview https://deploy-preview-9255--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. 5.0.0-beta labels Aug 29, 2024
@sarah11918
Copy link
Member

sarah11918 commented Sep 3, 2024

Updated comment: After speaking with Fred, I think we do want this on a page in the routing section. So, am starting to redraft a secondary page to see what it would look like with that focus.


### Benefits of server islands

The most obvious benefit of server islands is the ability to render the more highly dynamic parts of your page on the fly. This allows the outer shell and main content to be more aggressively cached, providing faster performance.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The most obvious benefit of server islands is the ability to render the more highly dynamic parts of your page on the fly. This allows the outer shell and main content to be more aggressively cached, providing faster performance.
Server islands is the ability to render the more highly dynamic parts of your page on the fly, leaving the outer shell and main content to be more aggressively cached, providing faster performance.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the push back I'd give here is that we don't really need to redefine server islands at this point. This section is about the benefits, and it should probably start like the client island section does, which is exactly this "The most obvious benefit".

Instead of removing that, if you had to fill in the blank to finish that (or a similar sentence), what would you say?

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, here's a few of my nits/thoughts 🙌

src/content/docs/en/concepts/islands.mdx Outdated Show resolved Hide resolved
src/content/docs/en/concepts/islands.mdx Outdated Show resolved Hide resolved
src/content/docs/en/concepts/islands.mdx Outdated Show resolved Hide resolved
src/content/docs/en/concepts/islands.mdx Outdated Show resolved Hide resolved
src/content/docs/en/concepts/islands.mdx Show resolved Hide resolved
src/content/docs/en/guides/server-islands.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/server-islands.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/server-islands.mdx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Sep 12, 2024
@github-actions github-actions bot removed the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Sep 12, 2024
@sarah11918 sarah11918 merged commit ec94a5c into 5.0.0-beta Sep 12, 2024
5 checks passed
@sarah11918 sarah11918 deleted the server-islands branch September 12, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0.0-beta add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants