Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document ViewTransitions API reference #9174
Document ViewTransitions API reference #9174
Changes from 3 commits
650508b
d0e6eff
7a48687
7eb8270
d4f21e1
536bdb3
3ad7338
1f960d4
9f4b672
ebc61a2
9549d50
a85c605
f383129
2454ee0
de47b05
c817614
18d6eeb
1fd61d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 2194 in src/content/docs/en/reference/api-reference.mdx
GitHub Actions / Check Links
Check failure on line 2206 in src/content/docs/en/reference/api-reference.mdx
GitHub Actions / Check Links
Check failure on line 2207 in src/content/docs/en/reference/api-reference.mdx
GitHub Actions / Check Links
Check failure on line 2233 in src/content/docs/en/reference/api-reference.mdx
GitHub Actions / Check Links
Check failure on line 2234 in src/content/docs/en/reference/api-reference.mdx
GitHub Actions / Check Links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a mystery to me. Do we have any examples of this anywhere? Why would you do that? And why does it cancel the next phase? Calling
preventDefault()
for theastro:before-preparation
event, on the other hand, is fine.If we do not persuade users of this, we do not need to warn them in the following
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen an example, nor can I think of any particular use case where you'd want to override this and not call the original at some point in the new function, but technically, you can.
I'm fine with not mentioning it on the docs tho.
Check failure on line 2367 in src/content/docs/en/reference/api-reference.mdx
GitHub Actions / Check Links