Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark functionPerRoute as deprecated #9108

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Mark functionPerRoute as deprecated #9108

merged 3 commits into from
Aug 20, 2024

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Aug 15, 2024 •
edited
Loading

Description (required)

Marks the functionPerRoute option as deprecated in the Vercel page.

Related issues & labels (optional)

@matthewp matthewp mentioned this pull request Aug 15, 2024
Merged
@netlify Netlify
Copy link

netlify bot commented Aug 15, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 2ef90c0
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66c4ab1e16afe3000889a667
😎 Deploy Preview https://deploy-preview-9108--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Aug 15, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/integrations-guide/vercel.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) and removed improve documentation Enhance existing documentation (e.g. add an example, improve description) labels Aug 15, 2024
sarah11918
sarah11918 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mattewP ! Fine to merge whenever you're ready!

@sarah11918 sarah11918 merged commit 2e42082 into main Aug 20, 2024
10 checks passed
@sarah11918 sarah11918 deleted the deprecate-function-per-route branch August 20, 2024 14:50
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Aug 20, 2024
@ArmandPhilippot
i18n(fr): update integrations-guide/vercel.mdx
b654254 
Add deprecation notice about `functionPerRoute` (see withastro#9108)
@ArmandPhilippot ArmandPhilippot mentioned this pull request Aug 20, 2024
Merged
@liruifengv liruifengv mentioned this pull request Aug 21, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Aug 21, 2024
Merged
dreyfus92 added a commit that referenced this pull request Aug 22, 2024
@ArmandPhilippot @dreyfus92
i18n(fr): update integrations-guide/vercel.mdx (#9154)
008a4eb 
Add deprecation notice about `functionPerRoute` (see #9108)

Co-authored-by: Paul Valladares <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewp @astrobot-houston @sarah11918