Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guides/routing): update Page interface and add link to API reference #8941

Conversation

ArmandPhilippot
Copy link
Member

Description (required)

Related issues & labels (optional)

Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0f414a4
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66a7cb25c32c040009086529
😎 Deploy Preview https://deploy-preview-8941--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jul 29, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/routing.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for tackling it! 🙌

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jul 29, 2024
@sarah11918 sarah11918 merged commit cf1d0e8 into withastro:main Jul 29, 2024
10 checks passed
@ArmandPhilippot ArmandPhilippot deleted the fix/guides-routing-update-page-interface branch July 29, 2024 17:13
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jul 29, 2024
yanthomasdev added a commit that referenced this pull request Aug 1, 2024
…pi-reference.mdx` (#8944)

* i18n(fr): Add `reference/api-refenrece.mdx` L0 to L501 now, miss L502 to L1026

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Add `reference/api-refenrece.mdx` L502 to L1026

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Fix links

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): translate api-reference.mdx from l1026 to end

* i18n(fr): Fix links, remove "NBSP" space and fix typo at "régionaux" L1570

Signed-off-by: Thomas Bonnet <[email protected]>

* Update src/content/docs/fr/reference/api-reference.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/reference/api-reference.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/reference/api-reference.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/reference/api-reference.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/reference/api-reference.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/reference/api-reference.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/reference/api-reference.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/reference/api-reference.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/reference/api-reference.mdx

Co-authored-by: Armand Philippot <[email protected]>

* i18n(fr): Update `reference/dev-toolbar-reference.mdx` from #8923

Signed-off-by: Thomas Bonnet <[email protected]>

* Update src/content/docs/fr/reference/api-reference.mdx

Co-authored-by: Armand Philippot <[email protected]>

* i18n(fr): Update `guides/routing.mdx` from #8941

Signed-off-by: Thomas Bonnet <[email protected]>

* Update src/content/docs/fr/reference/api-reference.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/routing.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/guides/routing.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Updating file since #8946

Co-authored-by: Armand Philippot <[email protected]>

* i18n(fr): Fix typo in from #8947

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `guides/routing.mdx` from #8967

Signed-off-by: Thomas Bonnet <[email protected]>

* i18n(fr): Update `reference/api-reference.mdx` from #8967

Signed-off-by: Thomas Bonnet <[email protected]>

* chore: Mettre à jour la documentation de référence de l'API

---------

Signed-off-by: Thomas Bonnet <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Yan <[email protected]>
@sarah11918 sarah11918 added the feedback-improvement Response to widget/Discord feedback label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback-improvement Response to widget/Discord feedback improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccurate Page interface for Pagination in Routing guide
3 participants