Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document addClientRenderer #8850

Merged
merged 5 commits into from
Jul 20, 2024
Merged

feat: document addClientRenderer #8850

merged 5 commits into from
Jul 20, 2024

Conversation

ematipico
Copy link
Member

Description (required)

This PR documents a API that was added to the container API

withastro/astro#11486

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit c26e30c
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/669b7b51b9b3560008cf4a92
😎 Deploy Preview https://deploy-preview-8850--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jul 18, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/container-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an initial review edit to see what you think, @ematipico !

I think there's so much in common here that it really can be the same section about adding renderers manually. See how you think this feels, and adjust if it's not accurate in some way!

@ematipico
Copy link
Member Author

Thank you @sarah11918, I like the new edits! I still think we should add the :::caution block because the order matters.

It isn't possible to use addClientRenderer before addServerRenderer. The function addServerRenderer must be called first.

@sarah11918
Copy link
Member

Ah, cool. I didn't get that the order mattered. Let me get back to that then! Thank you!

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Jul 19, 2024
@ematipico ematipico merged commit 44111d8 into main Jul 20, 2024
9 of 10 checks passed
@ematipico ematipico deleted the feat/client-renderer branch July 20, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants