Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(fr): update reading-time recipe #8685

Merged

Conversation

ArmandPhilippot
Copy link
Contributor

Description (required)

  • add Steps component from Eduardo <Steps> up! #8167
  • make instructions consistent (each bullet point should start with imperative or infinitive form and not a mix of both)

Related issues & labels (optional)

  • Suggested label: i18n

* add Steps component from withastro#8167
* make bullet points consistent (all in infinitive form)
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 26, 2024 0:31am

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 26, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 26, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr recipes/reading-time.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing 3 tabs, th rest is LGTM!

src/content/docs/fr/recipes/reading-time.mdx Outdated Show resolved Hide resolved
src/content/docs/fr/recipes/reading-time.mdx Outdated Show resolved Hide resolved
src/content/docs/fr/recipes/reading-time.mdx Outdated Show resolved Hide resolved
@ArmandPhilippot
Copy link
Contributor Author

Thanks @thomasbnt, I didn't notice it since they were already missing. It's fixed now! ;-)

Copy link
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing work, peeps!

@yanthomasdev yanthomasdev merged commit 9fc55be into withastro:main Jun 26, 2024
8 checks passed
@ArmandPhilippot ArmandPhilippot deleted the i18n/french-reading-time-recipe branch June 26, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants